Context: dotnet/android#662

The intention of [xamarin-android][xa]'s [api-compatibility][compat]
test is to ensure that API compatibility isn't broken by a commit.
The `api-compatibility` test works by using the `make check` target
in this repo (`xamarin-android-api-compatibility`).

Unfortunately, it's broken: API breakage which *should* be reported
*isn't* being reported.

The cause of the failure is the intermix of three things:

 1. The `make check` target redirects `mono-api-info` standard output
    to a file, a file which *must* be valid XML in order for the
    subsequent `mono-api-html` invocation to succeed

 2. When `mono-api-info`
    [encounters an error loading an assembly][assembly-error], the
    error message is written to standard output.

 3. For currently unknown reasons, the xamarin-android build system
    doesn't always copy debug symbols when it copies assemblies.

The result of this interplay is that when processing
`Mono.Android.dll`, the resulting `Mono.Android.xml` file is not
valid XML:

	Symbol file …/xamarin-android/bin/BuildDebug/Xamarin.Android.Cecil.pdb doesn't match image …/xamarin-android/bin/BuildDebug/Xamarin.Android.Cecil.dll
	<?xml version="1.0" encoding="utf-8"?>
	…

(I don't immediately know why `Xamarin.Android.Cecil.dll` is being
loaded while processing `Mono.Android.dll`. I just know that the
resulting intermediate `Mono.Android.xml` for API compatibility
checking starts with the above output.)

While all three factors can -- and should! -- be individually fixed,
it's easiest at this point in time to fix the first factor: instead
of redirecting `mono-api-info` standard output to `Mono.Android.xml`,
instead use `mono-api-info -o FILENAME`. This ensures that the
resulting file that we care about will contain valid XML.

[xa]: https://github.com/xamarin/xamarin-android
[compat]: https://github.com/xamarin/xamarin-android/tree/master/tests/api-compatibility
[assembly-error]: https://github.com/mono/mono/blob/a715c0daee65db97e2df1080ef42dc99436a3f52/mcs/tools/corcompare/mono-api-info.cs#L205

Context: #662

The intention of `xamarin-android`'s
[api-compatibility](tests/api-compatibility) test is to ensure that
API compatibility isn't broken by a commit. The `api-compatibility`
test works by using the `make check` target in the
[`xamarin-android-api-compatibility` repo][xa-compat].

Unfortunately, it was broken: API breakage which *should* be reported
*isn't* being reported.

The cause of the failure was the intermix of three things:

 1. The `make check` target redirects `mono-api-info` standard output
    to a file, a file which *must* be valid XML in order for the
    subsequent `mono-api-html` invocation to succeed

 2. When `mono-api-info`
    [encounters an error loading an assembly][assembly-error], the
    error message is written to standard output.

 3. For currently unknown reasons, the xamarin-android build system
    doesn't always copy debug symbols when it copies assemblies.

The result of this interplay is that when processing
`Mono.Android.dll`, the resulting `Mono.Android.xml` file is not
valid XML:

	Symbol file …/xamarin-android/bin/BuildDebug/Xamarin.Android.Cecil.pdb doesn't match image …/xamarin-android/bin/BuildDebug/Xamarin.Android.Cecil.dll
	<?xml version="1.0" encoding="utf-8"?>
	…

(I don't immediately know why `Xamarin.Android.Cecil.dll` is being
loaded while processing `Mono.Android.dll`. I just know that the
resulting intermediate `Mono.Android.xml` for API compatibility
checking starts with the above output.)

While all three factors can -- and should! -- be individually fixed,
it's easiest at this point in time to fix the first factor: instead
of redirecting `mono-api-info` standard output to `Mono.Android.xml`,
instead use `mono-api-info -o FILENAME`. This ensures that the
resulting file that we care about will contain valid XML.

Bump to xamarin-android-api-compatibility/master/0e1889b0 so that the
`mono-api-info` invocation uses `mono-api-info -o FILENAME`.

[xa-compat]: https://github.com/xamarin/xamarin-android-api-compatibility
[assembly-error]: https://github.com/mono/mono/blob/a715c0daee65db97e2df1080ef42dc99436a3f52/mcs/tools/corcompare/mono-api-info.cs#L205

…tion branch

See dotnet/android#662 for all those details.
Particularly dotnet/android#662 (comment)
for the latest details.

…tion branch

See dotnet/android#662 for all those details.
Particularly dotnet/android#662 (comment)
for the latest details.

…tion branch

See dotnet/android#662 for all those details.
Particularly dotnet/android#662 (comment)
for the latest details.

…tion branch

See dotnet/android#662 for all those details.
Particularly dotnet/android#662 (comment)
for the latest details.

Context: dotnet/android#662

There are three breaking changes in this update which we consider
to be acceptable:

1. Removal of `Android.Service.Quicksettings.TileState`
2. Removal of `Java.Lang.Reflect.Constructor.InterfaceConsts`
3. Removal of `Java.Lang.Reflect.Method.InterfaceConsts`

The `TileState` enum (1) is present due to a type-o: the namespace is
*supposed* to be `Android.Service.QuickSettings` (note the
capital-`S` in `QuickSettings`), and there is also an identical
`Android.Service.QuickSettings.TileState` enum type.

The incorrect `Android.Service.Quicksettings.TileState` type has been
`[Obsolete]` for quite some time, so we're removing it now.

The `InterfaceConsts` types (2, 3) are for `static final int` members
from a Java interface. (In this case, `Constructor` and `Method` are
*classes*, so the `InterfaceConsts` types were coming from interfaces
those types implement.)

Related: https://developer.xamarin.com/guides/android/advanced_topics/api_design/

> All classes that implement a Java interface containing constants
> get a new nested `InterfaceConsts` type which contains constants
> from all implemented interfaces.

However, the `InterfaceConsts` types are only emitted on types which
implement the interface.

In API-25, we had:

	// Java
	interface Member {
	  public static final int DECLARED  = 1;
	  public static final int PUBLIC    = 0;
	  // ...
	}
	class Constructor extends AccessibleObject implements Member {
	  // ...
	}

This resulted in the C# binding:

	// C#
	partial class Constructor : AccessibleObject, IMember {
	  public static class InterfaceConsts {
	    public const int Declared    = 1;
	    public const int Public      = 1;
	  }
	}

API-26 changes this: `Constructor` and `Method` no longer directly
implement the `Member` interface. Instead, they inherit from
`Executable`, which implements `Member`:

	// Java
	class Executable extends AccessibleObject implements Member {
	  // ...
	}
	class Constructor extends Executable {
	  // ...
	}

Which results in the binding:

	// C#
	partial class Executable : AccessibleObject, IMember {
	  public static class InterfaceConsts {
	    public const int Declared    = 1;
	    public const int Public      = 1;
	  }
	}
	partial class Constructor : Executable {
	}

*This* is the state of affairs for the "breaking change" in (2, 3):
the `Constructor.InterfaceConsts` and `Method.InterfaceConsts`
types are no longer generated.

However, *these are not breaking changes*.

The removal of e.g. `Constructor.InterfaceConsts` isn't an ABI break,
as it isn't possible for IL to reference any
`Constructor.InterfaceConsts` members: it's a static class with no
methods, only `const` fields. Thus, the `const` value will be
"inlined" at their usage sites, and there are no other members which
can be referenced from IL under normal usage.

Additionally, this isn't an API (source) break either: because the
`InterfaceConsts` type was "moved" to a base class, existing source
code with a C# expression of `Constructor.InterfaceConsts.Default`
will continue to compile as expected, with unchanged semantics.

We thus deem (2, 3) to be acceptable changes.

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473

Bump to xamarin-android-api-compatibility/master/6fe9b17f.

Add `Documentation/HowToAddNewApiLevel.md`, to describe the process
for binding new API levels, including enumification.

Enumify API-26.

Update `build-tools/enumification-helpers` to support the latest
droiddoc `packages.html` format.

API-26 changed `Activity.findViewById(int)` to be a generic method.
Remove the `<typeParameters/>` element and "fix" the return type so
that we don't break API compatibility, as `generator` doesn't
currently do anything sane here. (Specifically, all generic
paramaters are currently bound as `Java.Lang.Object`, *even if* the
type parameter has a constraint which provides a more specific type!)

Fix binding of `Java.Nio.FileChannel` so it can be actually bound,
related `SeekableByteChannel` support fixes.

Remove `//implements[@name='AutoCloseable']` and
`//implements[@name='Destryable']`, as they add Java `default`
interface methods which can't be sanely supported at this time.

Update `api-merge` to change `default` interface methods to
non-`default` methods when merging with an older API level which
contained the non-`default` interface method. This preserves backward
compatibility with existing assemblies and source code. Remove the
associated workarounds.

Bump xamarin-android-api-compatibility to check against the
latest-and-greatest API-26 binding.

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473

Bump to xamarin-android-api-compatibility/master/6fe9b17f.

Add `Documentation/HowToAddNewApiLevel.md`, to describe the process
for binding new API levels, including enumification.

Enumify API-26.

Update `build-tools/enumification-helpers` to support the latest
droiddoc `packages.html` format.

API-26 changed `Activity.findViewById(int)` to be a generic method.
Remove the `<typeParameters/>` element and "fix" the return type so
that we don't break API compatibility, as `generator` doesn't
currently do anything sane here. (Specifically, all generic
paramaters are currently bound as `Java.Lang.Object`, *even if* the
type parameter has a constraint which provides a more specific type!)

Fix binding of `Java.Nio.FileChannel` so it can be actually bound,
related `SeekableByteChannel` support fixes.

Remove `//implements[@name='AutoCloseable']` and
`//implements[@name='Destryable']`, as they add Java `default`
interface methods which can't be sanely supported at this time.

Update `api-merge` to change `default` interface methods to
non-`default` methods when merging with an older API level which
contained the non-`default` interface method. This preserves backward
compatibility with existing assemblies and source code. Remove the
associated workarounds.

Bump xamarin-android-api-compatibility to check against the
latest-and-greatest API-26 binding.

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473

Bump to xamarin-android-api-compatibility/master/6fe9b17f.

Add `Documentation/HowToAddNewApiLevel.md`, to describe the process
for binding new API levels, including enumification.

Enumify API-26.

Update `build-tools/enumification-helpers` to support the latest
droiddoc `packages.html` format.

API-26 changed `Activity.findViewById(int)` to be a generic method.
Remove the `<typeParameters/>` element and "fix" the return type so
that we don't break API compatibility, as `generator` doesn't
currently do anything sane here. (Specifically, all generic
paramaters are currently bound as `Java.Lang.Object`, *even if* the
type parameter has a constraint which provides a more specific type!)

Fix binding of `Java.Nio.FileChannel` so it can be actually bound,
related `SeekableByteChannel` support fixes.

Remove `//implements[@name='AutoCloseable']` and
`//implements[@name='Destryable']`, as they add Java `default`
interface methods which can't be sanely supported at this time.

Update `api-merge` to change `default` interface methods to
non-`default` methods when merging with an older API level which
contained the non-`default` interface method. This preserves backward
compatibility with existing assemblies and source code. Remove the
associated workarounds.

Bump xamarin-android-api-compatibility to check against the
latest-and-greatest API-26 binding.

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473

Bump to xamarin-android-api-compatibility/master/6fe9b17f.

Add `Documentation/HowToAddNewApiLevel.md`, to describe the process
for binding new API levels, including enumification.

Enumify API-26.

Update `build-tools/enumification-helpers` to support the latest
droiddoc `packages.html` format.

API-26 changed `Activity.findViewById(int)` to be a generic method.
Remove the `<typeParameters/>` element and "fix" the return type so
that we don't break API compatibility, as `generator` doesn't
currently do anything sane here. (Specifically, all generic
paramaters are currently bound as `Java.Lang.Object`, *even if* the
type parameter has a constraint which provides a more specific type!)

Fix binding of `Java.Nio.FileChannel` so it can be actually bound,
related `SeekableByteChannel` support fixes.

Remove `//implements[@name='AutoCloseable']` and
`//implements[@name='Destryable']`, as they add Java `default`
interface methods which can't be sanely supported at this time.

Update `api-merge` to change `default` interface methods to
non-`default` methods when merging with an older API level which
contained the non-`default` interface method. This preserves backward
compatibility with existing assemblies and source code. Remove the
associated workarounds.

Bump xamarin-android-api-compatibility to check against the
latest-and-greatest API-26 binding.

Changes: dotnet/java-interop@b00e644...1de5501

  * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655)
  * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662)
  * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659)
  * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660)
  * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657)
  * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656)
  * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658)
  * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654)
  * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652)
  * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650)
  * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)

Changes: dotnet/java-interop@76d1ac7...1f3388a

  * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662)
  * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (dotnet#659)
  * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (dotnet#660)
  * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (dotnet#658)
  * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (dotnet#652)
  * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650)
  * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)

Changes: dotnet/java-interop@76d1ac7...1f3388a

  * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662)
  * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (dotnet#659)
  * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (dotnet#660)
  * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (dotnet#658)
  * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (dotnet#652)
  * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650)
  * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)

Changes: dotnet/java-interop@b00e644...1de5501

  * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655)
  * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662)
  * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659)
  * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660)
  * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657)
  * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656)
  * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658)
  * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654)
  * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652)
  * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650)
  * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)

Changes: dotnet/java-interop@b00e644...1de5501

  * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (dotnet#655)
  * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (dotnet#662)
  * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (dotnet#659)
  * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (dotnet#660)
  * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (dotnet#657)
  * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (dotnet#656)
  * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (dotnet#658)
  * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (dotnet#654)
  * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (dotnet#652)
  * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (dotnet#650)
  * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (dotnet#651)

Changes: dotnet/java-interop@76d1ac7...1f3388a

  * dotnet/java-interop@1f3388a: [generator] Use proper syntax for nested classes for DIM invokers (#662)
  * dotnet/java-interop@5e23163: [generator] Support XML defined enums with no JNI info (#659)
  * dotnet/java-interop@5c4581d: [generator] Don't invalidate interface if static method is invalidated (#660)
  * dotnet/java-interop@9687bb5: Bump to xamarin/xamarin-android-tools/d16-7@017078f2 (#658)
  * dotnet/java-interop@abfade5: [Java.Interop] Fix C# warnings (#652)
  * dotnet/java-interop@fb6d5f9: [Java.Interop.Tools.Generator] Specify $(OutputPath) (#650)
  * dotnet/java-interop@a3f148c: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (#651)

Changes: dotnet/java-interop@b00e644...1de5501

  * dotnet/java-interop@1de5501: [CI] Add an "macOS .NET Core" build (#655)
  * dotnet/java-interop@9a56465: [generator] Use proper syntax for nested classes for DIM invokers (#662)
  * dotnet/java-interop@267c3f3: [generator] Support XML defined enums with no JNI info (#659)
  * dotnet/java-interop@5dcf896: [generator] Don't invalidate interface if static method is invalidated (#660)
  * dotnet/java-interop@1b59dcc: [java-interop] Update to SDK style project (#657)
  * dotnet/java-interop@b136ac9: [param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (#656)
  * dotnet/java-interop@eb39a3a: Bump to xamarin/xamarin-android-tools/master@3974fc38 (#658)
  * dotnet/java-interop@a99b451: [logcat-parse] Update to Mono.Terminal 5.4.0 (#654)
  * dotnet/java-interop@425f79d: [Java.Interop] Fix C# warnings (#652)
  * dotnet/java-interop@2e0f55d: [Java.Interop.Tools.Generator] Specify $(OutputPath) (#650)
  * dotnet/java-interop@4b266fa: [Xamarin.Android.Tools.Bytecode] Support @jvmoverloads (#651)